Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: Update Close Button component #138

Closed
2 of 3 tasks
Aveline-art opened this issue Feb 3, 2022 · 1 comment
Closed
2 of 3 tasks

Accessibility: Update Close Button component #138

Aveline-art opened this issue Feb 3, 2022 · 1 comment
Labels
feature: Design System PBV: dev all issues for engineering roles (devops, backend, frontend, db) role: frontend Pertains to frontend tasks size: 2pt Can be done in 7-12 hours
Milestone
06 - Landing Page...

Comments

@Aveline-art
Copy link
Member

Aveline-art commented Feb 3, 2022 •
edited
Loading

Overview

As a developer, we need to make sure that our components are accessible as much as humanly possible. For this issue we will update our component for accessibility.

Action Items

  • Wrap the CloseButton with html tags
  • For the <img> tag, add an appropriate alt text (which might be blank, if it is purely decorative)
  • Perform other tasks as needed to ensure accessibility, such as aria labels

Resources/Instructions

3.5 Button
@Aveline-art Aveline-art added dependency This item depends on something p-feature: Components role: frontend Pertains to frontend tasks size: 2pt Can be done in 7-12 hours labels Feb 3, 2022
@sdimran sdimran added this to the 06 - Landing Page 1 (initial) milestone Feb 6, 2022
@Aveline-art Aveline-art added ready for milestone and removed dependency This item depends on something labels Apr 28, 2022
@Aveline-art Aveline-art mentioned this issue Apr 30, 2022
Closed
6 tasks
@Aveline-art Aveline-art moved this from 🆕 New to 📋 Backlog in P: CTJ: Project Board May 12, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the PBV: dev all issues for engineering roles (devops, backend, frontend, db) label Jun 12, 2024
@nooriaali9
Copy link
Member

Closing this issue - since it is outdated/ not a priority anymore - based off of #552

@github-project-automation github-project-automation bot moved this from 📋 Prioritized Backlog to ✅ Done in P: CTJ: Project Board Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature: Design System PBV: dev all issues for engineering roles (devops, backend, frontend, db) role: frontend Pertains to frontend tasks size: 2pt Can be done in 7-12 hours
Projects
P: CTJ: Project Board
Archived in project
Milestone
06 - Landing Page 1 (initial)
Development

No branches or pull requests
6 participants
@sdimran @nooriaali9 @ExperimentsInHonesty @Aveline-art @jenchuu @luca-navarrete