Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: How to resolve PR merge conflicts when another contributor made a previous PR #120

Open
6 tasks
fyliu opened this issue Jun 12, 2023 · 1 comment
Open
6 tasks
Labels
size: 1pt Can be done in 4-6 hours

Comments

@fyliu
Copy link
Member

fyliu commented Jun 12, 2023

Dependency

Overview

We need documentation to guide developers in resolving this common problem. 2 devs start with the same base commit, the first one to create a PR is okay, but the 2nd dev to create a PR will have some conflicts in their PR, even though it runs fine.

Action Items

  • write doc to explain and guide to find the solution
  • check the website team's guide on the same topic
    • if there are common sections
      • copy the relevant portion into a new guide in the Engineering CoP docs repo. Note which projects are referencing the guide.
      • link from our docs while removing those sections
      • notify website team to examine the content and link it from their docs

Resources/Instructions

Discussion

The preferred solution is to rebase the new PR to the new HEAD of the main branch and resolve any conflicts so that the PR can be merged smoothly.

See discussion on this topic

@ExperimentsInHonesty
Copy link
Member

This might be something we want the engineering cop to write. If they won't write is, we will write our own custom version.

@fyliu fyliu changed the title Add documentation on how to resolve PR merge conflicts when another contributor made a previous PR [docs] Document how to resolve PR merge conflicts when another contributor made a previous PR Jun 3, 2024
@fyliu fyliu changed the title [docs] Document how to resolve PR merge conflicts when another contributor made a previous PR [docs] How to resolve PR merge conflicts when another contributor made a previous PR Jun 3, 2024
@fyliu fyliu changed the title [docs] How to resolve PR merge conflicts when another contributor made a previous PR docs: How to resolve PR merge conflicts when another contributor made a previous PR Jun 10, 2024
@ExperimentsInHonesty ExperimentsInHonesty transferred this issue from hackforla/peopledepot Nov 15, 2024
@ExperimentsInHonesty ExperimentsInHonesty transferred this issue from hackforla/guides Nov 15, 2024
@shmonks shmonks moved this to Needs to be Triaged in P: Guides: Knowledgebase Content Tracker Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: 1pt Can be done in 4-6 hours
Projects
Status: Needs to be Triaged
Development

No branches or pull requests

2 participants