-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Projects from "Our Locations" section of Events page #2497
Comments
Hi @kristine-eudey. Good job adding the required labels for this issue. The @hackforla/website-merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization. Additional Resources: |
Progress: Assigned to self 11/30 |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Monday, December 6, 2021 at 11:19 PM PST. |
Redesigned to show 3 location image cards and removed all day of the week and project information. Ready for review. |
@jenjen26 This looks good to me! |
@jenjen26 Please make the desktop version the same square as the mobile. |
@ExperimentsInHonesty @IsaacDesigns Changing the desktop version to square appears to go against the design system currently. I am more than willing to make the change - just wanted to confirm prior to completing. |
@jenjen26 Thanks for addressing this and going off of the design system. We can review this in Thursday's meeting. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Monday, January 10, 2022 at 11:19 PM PST. |
@jen please add in a comment where in the design system it says to make the Desktop cards rectangle rather than square. |
@IsaacDesigns Since we've removed the text section to the right of the image on the card, we may want to add a square image design to the design system if that is the preference. |
@jenjen26 yes we have agreed that we will go with your square image design and we will have to add this new square image to the design system. |
Progress: I added this to the Large Cards in the design system. |
@jenjen26 Next Steps:
|
@jenjen26 Thanks for the new work. Looks perfect, we will turn it over to Development now to make a new issue where they define the classes that are currently in use by adding them to the design system (because it seems like they are missing now). |
Dev follow up issue for this is #3027 |
Overview
We need to remove the Projects from the "Our Locations" section of Events page in order to more accurately reflect the now fully-remote nature of the organization. We need to keep the 3 photo tiles for Westside, Downtown, and South LA in order to show HfLA's base and connection to the Los Angeles area.
Action Items
Duplicate the Events Page in Figma (both desktop and mobile)
Remove the right hand section of the 3 location cards (The section that shows day of week and Projects)
Redesign this section of the page to just feature the 3 images (Westside, Downtown, and South LA) and put them all the on the same row.
Resources/Instructions
HfLA - Events
Figma - Events
HfLA Design System
The text was updated successfully, but these errors were encountered: