Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Projects from "Our Locations" section of Events page #2497

Closed
3 tasks done
kristine-eudey opened this issue Nov 17, 2021 · 16 comments
Closed
3 tasks done

Remove Projects from "Our Locations" section of Events page #2497

kristine-eudey opened this issue Nov 17, 2021 · 16 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Events https://www.hackforla.org/events/ role: design size: missing Status: Updated No blockers and update is ready for review
Milestone

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Nov 17, 2021

Overview

We need to remove the Projects from the "Our Locations" section of Events page in order to more accurately reflect the now fully-remote nature of the organization. We need to keep the 3 photo tiles for Westside, Downtown, and South LA in order to show HfLA's base and connection to the Los Angeles area.

Action Items

  • Duplicate the Events Page in Figma (both desktop and mobile)

  • Remove the right hand section of the 3 location cards (The section that shows day of week and Projects)
    Screen Shot 2021-11-17 at 12 28 18 PM

  • Redesign this section of the page to just feature the 3 images (Westside, Downtown, and South LA) and put them all the on the same row.

    • Refer to the design system, and other designs on the site utilizing photo grids, like the homepage for example.

Resources/Instructions

HfLA - Events
Figma - Events
HfLA Design System

@kristine-eudey kristine-eudey added P-Feature: Events https://www.hackforla.org/events/ role: design Complexity: Small Take this type of issues after the successful merge of your second good first issue Ready for Prioritization labels Nov 17, 2021
@github-actions
Copy link

Hi @kristine-eudey.

Good job adding the required labels for this issue. The @hackforla/website-merge team will review the issue and add a "Ready for Milestone" label once it is ready for prioritization.

Additional Resources:

@jenjen26
Copy link
Member

Progress: Assigned to self 11/30
Blockers: none currently
Availability: ~10hrs this week
ETA: 12/10

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed Status: Updated No blockers and update is ready for review labels Dec 3, 2021
@github-actions
Copy link

@jenjen26

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, December 6, 2021 at 11:19 PM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Dec 10, 2021
@jenjen26
Copy link
Member

jenjen26 commented Dec 10, 2021

Redesigned to show 3 location image cards and removed all day of the week and project information. Ready for review.

Redesign of events page for desktop and mobile
Screenshot 2021-12-10 144729

@jenjen26 jenjen26 added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Dec 10, 2021
@IsaacDesigns
Copy link
Member

@jenjen26 This looks good to me!

@ExperimentsInHonesty
Copy link
Member

@jenjen26 Please make the desktop version the same square as the mobile.

@jenjen26
Copy link
Member

jenjen26 commented Jan 3, 2022

@ExperimentsInHonesty @IsaacDesigns Changing the desktop version to square appears to go against the design system currently. I am more than willing to make the change - just wanted to confirm prior to completing.

@IsaacDesigns
Copy link
Member

@jenjen26 Thanks for addressing this and going off of the design system. We can review this in Thursday's meeting.

@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Jan 14, 2022
@github-actions
Copy link

@jenjen26

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Monday, January 10, 2022 at 11:19 PM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jan 14, 2022
@IsaacDesigns
Copy link
Member

@jen please add in a comment where in the design system it says to make the Desktop cards rectangle rather than square.

@jenjen26
Copy link
Member

@IsaacDesigns
The new locations page follows the 'large card' format in the design system for the image, which was what the old locations page was using.

Since we've removed the text section to the right of the image on the card, we may want to add a square image design to the design system if that is the preference.

@jenjen26 jenjen26 added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Jan 20, 2022
@IsaacDesigns
Copy link
Member

@jenjen26 yes we have agreed that we will go with your square image design and we will have to add this new square image to the design system.

@jenjen26
Copy link
Member

Progress: I added this to the Large Cards in the design system.
Blockers: how to complete CSS and naming convention portion in design system
ETA 01/31

@ExperimentsInHonesty
Copy link
Member

@jenjen26
FYI: When you put things in the review column, please be as specific as possible about who needs to review and why. This will ensure that you get the fastest response possible E.g. on this issue you could have written:

Next Steps:

  • For Design Team or Design Lead to review and sign off or provide comments
  • When design team or lead is done, Product team needs to review and provide sign off or comments.

@ExperimentsInHonesty
Copy link
Member

@jenjen26 Thanks for the new work. Looks perfect, we will turn it over to Development now to make a new issue where they define the classes that are currently in use by adding them to the design system (because it seems like they are missing now).

@JessicaLucindaCheng
Copy link
Member

Dev follow up issue for this is #3027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue P-Feature: Events https://www.hackforla.org/events/ role: design size: missing Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

6 participants