Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primary_care and hospital_inpatient data loading code missing? #4

Open
cipherome-minkim opened this issue Jul 16, 2020 · 3 comments
Open
Assignees

Comments

@cipherome-minkim
Copy link

Describe the bug

Load Electronic Health Records
seems to suggest that it can load hesin data, but

  1. that code block is missing the actual ukbrest image & command option. it should be more like
$ docker run --rm --net ukb \
-e UKBREST_DB_URI="postgresql://test:test@pg:5432/ukb" \
-v ~/hospital_inpatient:/var/lib/hospital_inpatient \
-v ~/primary_care:/var/lib/primary_care
  hakyimlab/ukbrest --load-???
  1. I don't see any code that would load those data files :p

Thanks!

@meliao
Copy link

meliao commented Jul 17, 2020

Hello and thank you for your interest in ukbREST!

I updated the documentation just before discovering a few bugs in the SQL schema defined for the EHR. I've discovered that the schema is not robust to all of the possible EHR downloads from the UK Biobank. I am still working on updating the schema.

In the meantime, I have opened a branch EHR_development with the development code in pull request #5.

I'll leave this issue open until I have completed the update to the schema.

In the meantime, please feel free to use the EHR_development branch!

@meliao meliao self-assigned this Jul 17, 2020
@miltondp
Copy link
Collaborator

Thank you, @cipherome-minkim! @meliao, maybe we should update the wiki to reflect the fact that this is in development and not stable yet.

@meliao
Copy link

meliao commented Jul 17, 2020

@miltondp Absolutely! I'll do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants