Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with accented characters #27

Open
jlecour opened this issue Dec 30, 2013 · 3 comments
Open

Problem with accented characters #27

jlecour opened this issue Dec 30, 2013 · 3 comments

Comments

@jlecour
Copy link

jlecour commented Dec 30, 2013

Hi,

Sometimes (often), I have a blank mdr window.

I took a few minutes to look into this and found that it's an issue with accented characters.

Here is a sample diff that will always produce a blank window :

diff --git file.rb file.rb
index 0123456..6543210 100644
--- file.rb
+++ file.rb
@@ -2,7 +2,7 @@
 line2
 line3
 line4
-old_line5 è
+new_line5 é
 line6
 line7
 line8

Strangely enough, if the accented letters are the same, it works.

@halffullheart
Copy link
Owner

I was able to reproduce this on the Mac version. I have not tested Linux or Windows yet. Probably an issue with all non ASCII characters.

@madx
Copy link
Contributor

madx commented Feb 20, 2014

I confirm this happens on Linux too

@halffullheart halffullheart added this to the vNext milestone Feb 20, 2014
@halffullheart halffullheart reopened this Mar 1, 2014
@halffullheart
Copy link
Owner

MDR does not handle unicode characters correctly. It assumes 1 byte = 1 character. Noob mistake of mine back when I originally wrote this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants