Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nodejs runtime #191

Open
metacosm opened this issue Jan 16, 2020 · 13 comments
Open

Fix nodejs runtime #191

metacosm opened this issue Jan 16, 2020 · 13 comments
Assignees

Comments

@metacosm
Copy link
Collaborator

No description provided.

@metacosm metacosm self-assigned this Jan 16, 2020
@lholmquist
Copy link

Anything that myself or @helio-frota might be able to help with?

@metacosm
Copy link
Collaborator Author

@lholmquist thanks but I first need to assess the situation… the problem is that halkyon expects some commands to be available in the target runtime image. For java-based runtimes, we have a specific image that we use: https://github.com/halkyonio/container-images/tree/master/hal-mvn-jdk. I need to see if we could have a better system so that we could use arbitrary runtime images, in particular the standard node.js images.

@metacosm
Copy link
Collaborator Author

metacosm commented Jan 17, 2020

@lholmquist @helio-frota: how does one access registry.access.redhat.com/ubi8/nodejs-12? Seems like halkyon cannot pull the image… If the image is customer-only, then we won't be able to use it.

@lholmquist
Copy link

the ubi images are the "community images" and should be available to everyone

@metacosm
Copy link
Collaborator Author

metacosm commented Jan 17, 2020 via email

@lholmquist
Copy link

can you run this locally docker run -it --rm registry.access.redhat.com/ubi8/nodejs-12 /bin/bash

@metacosm
Copy link
Collaborator Author

The problem is that it's the operator that cannot pull the image. I can pull and execute stuff off of the image locally just fine.

@metacosm metacosm added this to the Snowdrop - 2020 - Q1 milestone Jan 20, 2020
@lholmquist
Copy link

. I can pull and execute stuff off of the image locally just fine.
I just wanted to make sure it was available.

Nodeshift actually use this registry.access.redhat.com/ubi8/nodejs-10 which is the node 10 version. could you try that instead of 12

@lholmquist
Copy link

I've written a little node.js code that pulls this image to see if things would work from code, and it seems to work, would someone be able to verify, https://github.com/lholmquist/docker-node-pull

@helio-frota
Copy link

That's right, @metacosm probably this is something with golang code that pulls the image and/or the external library/dependency because the code I wrote is not working https://github.com/helio-frota/try-to-pull but the library @lholmquist used works.

@metacosm
Copy link
Collaborator Author

I'll take a look tomorrow but I don't control the code that pulls the image: it's Kubernetes doing it… 😄
There's probably a setting that we missed somewhere. I'll also take another more attentive look at the thread you mentioned because I only followed it from far away 😁

@helio-frota
Copy link

@metacosm hi, any update on this ?
No rush, but just myself to organize and sync my other tasks 👍

@cmoulliard
Copy link
Contributor

Do you plan to work on this task this week ? When will it be delivered as part of a next release ? Can you apply the label as defined here : https://github.com/snowdrop/snowdrop-team/labels?q=- ? @metacosm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants