[Proposition] Use the vault kv2 key to store all the parameters

[cmoulliard]

Proposition

Until now, we use the following kv key to store the username/password. Primaza, when it will read the content of the key assumes that the first parameter corresponds to the username and the second as the password

vault kv put -mount=secret primaza/fruits healthy=healthy

if (StringUtils.isNotEmpty(credential.vaultKvPath)) {
         Map<String, String> vaultSecret = kvSecretEngine.readSecret(credential.vaultKvPath);
         Set<String> usernames = vaultSecret.keySet();
         username = usernames.iterator().next();
         password = vaultSecret.get(username);
}

Remark: While this approach is minimalist and simplistic, it do not guarantee that the first parameter is well the username like alse the second the password

I would like to propose that we store under the secret path the different parameters such as username, password, database, ...
This way of working is currently supported by the kv2 storing engine

vault kv put -mount=secret primaza/fruits username=healthy password=healthy database=fruits_database

One immediate benefit of this approach will be that Primaza can control if the expected keys are well present.

Note: Alternatively, we could also delegate to the operator creating the entries on vault, the responsibility to define the different keys according to what the application expects to get. This point should be discussed part of the ticket #295

WDYT ? @aureamunoz @Sgitario @iocanel @dperaza4dustbit @filariow

[iocanel]

This is a great improvement over what you already have there. So clearly +1.

Is there any chance you might need multiple accounts for a service?

[aureamunoz]

+1 Too

[cmoulliard]

Is there any chance you might need multiple accounts for a service?

Yes certainly as a Service is never installed to be used by one user ;-)