Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove role template #46

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ruibaby
Copy link
Member

@ruibaby ruibaby commented Jun 22, 2024

因为此插件的定位,基本上只有超级管理员才有使用的可能,所以建议直接移除 Role Template 定义,并且将 Console 入口的 UI 权限限制为超级管理员。

修改插件的权限逻辑,改为仅面向超级管理员可用。

@f2c-ci-robot f2c-ci-robot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 22, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from guqing and JohnNiang June 22, 2024 15:16
Copy link
Member

@guqing guqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2024
Copy link
Member

@LIlGG LIlGG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

f2c-ci-robot bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: guqing, LIlGG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@f2c-ci-robot f2c-ci-robot bot merged commit a7f44cf into halo-sigs:main Jun 24, 2024
2 checks passed
@ruibaby ruibaby deleted the refactor/remove-role-template branch October 20, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants