Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image tools missing raises exception #1942

Open
roleyfoley opened this issue Feb 22, 2022 · 0 comments
Open

Image tools missing raises exception #1942

roleyfoley opened this issue Feb 22, 2022 · 0 comments

Comments

@roleyfoley
Copy link
Contributor

Expected Behaviour

When docker cannot be accessed to pull a required docker image the generation process should fail and return an exception

Current Behaviour

When working with docker image pulls if a docker command cannot be found during an pregeneration script a warning is logged in the script but the process continues

Possible Solution

This was before the introduction of the HAMLET_SKIP_IMAGE_PULL env var which was added to work around scenarios where you are testing deployment generation offline and don't want the image skipped. The soft fail was an attempt to work around this, the env var configuration is more explicit and ensures that its acknowledged by users that the pull failed

Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant