Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove SIG4ORIP and SIG4ANDIP from the AWS provider #1997

Open
ml019 opened this issue May 22, 2022 · 0 comments
Open

Remove SIG4ORIP and SIG4ANDIP from the AWS provider #1997

ml019 opened this issue May 22, 2022 · 0 comments
Labels
enhancement requires breaking change

Comments

@ml019
Copy link
Contributor

ml019 commented May 22, 2022 •
edited
Loading

Expected Behaviour

Being very AWS specific, a prefixed value should be used.

Current Behaviour

AWS specific values were added as part of hamlet-io/engine-plugin-aws#581
and the shared values also moved here. Either the prefixed or non-prefixed values can currently be used.

Possible Solution

  • Remove SIG4ORIP and SIG4ANDIP from the AWS provider
  • Rely on the prefixed values in the AWS provider if a SIG4 based model is required.

Context

  • make configuration process more logical
@ml019 ml019 mentioned this issue May 22, 2022
Merged
@ml019 ml019 changed the title Remove SIG4ORIP and SIG4ANDIP from shared provider Remove SIG4ORIP and SIG4ANDIP from the AWS provider May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement requires breaking change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ml019