Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include basic util binaries in repo #221

Open
roleyfoley opened this issue Jun 9, 2021 · 1 comment
Open

Include basic util binaries in repo #221

roleyfoley opened this issue Jun 9, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@roleyfoley
Copy link
Contributor

Expected Behaviour

When calling jq or dos2unix the binaries are sourced from the bash exector code repo itself

Current Behaviour

We rely on them being available on PATH

Possible Solution

  • Include a windows(mingw), osx and linux compiled binary of jq and dos2unix in the executor code repo
  • Include a bash script for the binaries which checks the uname for the right binary version
  • During common.sh or something like that processing update the PATH variable to include the path to these binary files

Context

The jq and dos2unix binaries are pretty small so it seems worthwhile to include them as part of our code to remove the reliance on os installed packages which can be complicated and hard to make this understandable to users

@roleyfoley roleyfoley added the enhancement New feature or request label Jun 9, 2021
@ml019
Copy link
Contributor

ml019 commented Jun 10, 2021

Another solution for dos2unix is just provide a python script with that name. ITs probably three lines of code...

jq is a bit trickier but it disappears when the bash executor disappears

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants