Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Window? #97

Open
kasettli opened this issue Aug 30, 2022 · 1 comment
Open

Wrong Window? #97

kasettli opened this issue Aug 30, 2022 · 1 comment
Assignees
@hammal
Milestone
0.4.0

Comments

@kasettli
Copy link
Collaborator

cbadc/src/cbadc/utilities.py

Line 428 in 527210f

window = scipy.signal.windows.blackman(N)

This is probably a typo, but should'nt this be scipy.signal.windows.hann(N)? Assuming you meant Hann and not Hamming window.

Although I see there is no window parameter currently, so maybe that is coming in a feature version :)
@hammal
Copy link
Owner

hammal commented Sep 5, 2022

Nice one :). Maybe it's time to finish that function and add the function argument!

@hammal hammal self-assigned this Dec 2, 2024
@hammal hammal added this to the 0.4.0 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hammal hammal

Labels
None yet
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@hammal @kasettli