Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cohorts does not work with latest mhctools #202

Open
tavinathanson opened this issue May 5, 2017 · 2 comments
Open

Cohorts does not work with latest mhctools #202

tavinathanson opened this issue May 5, 2017 · 2 comments

Comments

@tavinathanson
Copy link
Member

From @julia326:

/home/julia/envs/smoking3/lib/python3.4/site-packages/cohorts/cohort.py in <module>()
     41 import varcode
     42 from varcode import EffectCollection, VariantCollection
---> 43 from mhctools import NetMHCcons, EpitopeCollection
     44 from topiary import predict_epitopes_from_variants, epitopes_to_dataframe
     45 from topiary.sequence_helpers import contains_mutant_residues
@tavinathanson
Copy link
Member Author

Travis didn't fail because of requirements.txt:

mhctools>=0.3.0, <0.4.0

That has been used a bunch to ensure that we're not automatically upgrading to a breaking change situation. It did in fact prevent Cohorts from being broken, but failed at alerting us that it was broken for the latest mhctools.

Note: any general discussion of versioning and package management should probably not go in this issue.

@tavinathanson
Copy link
Member Author

The latest Topiary will probably break Cohorts as well: https://github.com/hammerlab/cohorts/blob/master/requirements.txt#L4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant