Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support safely resubmitting workflows if an earlier version of that workflow is partially running #493

Open
ihodes opened this issue Oct 31, 2016 · 2 comments

Comments

@ihodes
Copy link
Member

ihodes commented Oct 31, 2016

This can fail due to race conditions now: e.g. a cleanup node to rm a failed .bam write gets killed, then you have a broken product (truncated .bam) if you kill before resubmitting. If you don't kill, then you might submit and have a .bam cleaned up between the new node being marked completed due to the truncated/broken .bam existing, thus making the new workflow fail as the .bam is rmed out from under it.

@smondet
Copy link
Member

smondet commented Oct 31, 2016

When a workflow is partiallly running "equivalence" is fine; the problem here is partially "killed" or "failed" workflows that are still in the process of “cleaning-up”.

@ihodes
Copy link
Member Author

ihodes commented Oct 31, 2016

Exactly, though I think that if a "cleanup" (on_failure) node was implemented as a conditional normal (depends_on) node, it'd still be a problem. Nevertheless, somewhat tangential to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants