Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[avar2] varStoreOffset -> itemVariationStoreOffset #95

Open
Lorp opened this issue Jun 22, 2023 · 2 comments
Open

[avar2] varStoreOffset -> itemVariationStoreOffset #95

Lorp opened this issue Jun 22, 2023 · 2 comments

Comments

@Lorp
Copy link
Collaborator

Lorp commented Jun 22, 2023

Just a minor comment, suggesting changing the field name in the avar2 table from varStoreOffset to itemVariationStoreOffset for the sake of consistency and clarity.

AFAICT all other ItemVariationStore tables are referred to this way. Some updates of “varStore” in the text will also be needed, if this change is accepted.
@behdad
Copy link
Member

behdad commented Jun 22, 2023

Sounds good to me. Thanks

@liamquin
Copy link
Collaborator

liamquin commented Jul 9, 2023

(updated in draft)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@behdad @Lorp @liamquin