HRC-721 images not showing

[justinasfour04]

I'm not sure if this is the issue but it seems like if the nft.uri is missing the following place holder gets displayed

chrome-extension-wallet/src/popup/pages/Token/HRC721/Gallery.vue

Line 21 in cc1e524

<div class="nft-item" v-else-if="nft.uri">

The nfts of Harmonauts are missing the URI but I looked at the 721 protocol and it doesn't seem like it's needed.
Can someone look into why the NFT images are not appearing on the wallet

chrome-extension-wallet/src/services/Hrc721Service.js

Line 20 in cc1e524

export async function getTokenURI(tokenid, contractAddress) {

This function is getting called in the vue to get the uri given the owner id. Something is preventing it from retrieving the uri

[sophoah]

@ethlocker are you the correct person to look at that issue ?

[datpenguinclub]

@ethlocker @sophoah have fixed this issue in this PR, please review and merge - #109

[justinasfour04]

When should we see the changes in the extension? Do we have to manually update?

[datpenguinclub]

@justinasfour04 have raised this with on Twitter - https://twitter.com/DatPenguinClub/status/1454099046944149505?s=20

Retweet and remind them to update the release

[justinasfour04]

@datpenguinclub is it updated ?

[datpenguinclub]

@justinasfour04 yes mate - it's updated - also our pre-sale is live at https://datpenguinclub.com . Come and mint yourself a 🐧 and view them in the browser extension wallet in all their glory. 😉😅

[datpenguinclub]

also @justinasfour04 chrome automatically updates all extensions, so I don't think you have to manually update it - but the version that has the fix is 1.2.5 - the latest one

[justinasfour04]

It doesn't seem to be working. I still get the NFT icon

[datpenguinclub]

@justinasfour04 could you right click your chrome extension and press "Manage Extension" and make sure that your wallet is on the latest version - 1.2.5

[justinasfour04]

[datpenguinclub]

@justinasfour04 cool - but with the latest version - with my fix - I'm able to view the NFT along with their attributes

[justinasfour04]

I am not

[justinasfour04]

I guess I'll fork it and make the change myself and then add to review

[datpenguinclub]

@justinasfour04 - could you exit out of the pop-up and open it back up again if it renders - if not it maybe that the asset associated with your NFT is no longer available

[datpenguinclub]

@justinasfour04 Well there's no change to be made - this was the change that was preventing the render #109

[justinasfour04]

It works perfectly fine on Metamask, why does this have to be any different. Also I know that all the metadata is there for those NFTs I have

[justinasfour04]

[justinasfour04]

stuck forever loading

[datpenguinclub]

that's on the right path

[datpenguinclub]

close the pop-up and open it back up again

[justinasfour04]

I am doing that

[datpenguinclub]

@justinasfour04 - I reckon the only solution left is uninstalling the chrome extension and re-installing it

[datpenguinclub]

@justinasfour04 and to check if it works - come mint a 🐧 at https://datpenguinclub.com 😉

[justinasfour04]

I'm not minting a penguin just to see that it works.

[justinasfour04]

Removed extension and added it back. Not a single NFT loads

[datpenguinclub]

@justinasfour04 well you could try it on the testnet - https://test.datpenguinclub.com - use the faucet https://faucet.pops.one/ to give yourself some ONE on the test network - and you could mint a penguin on test.datpenguinclub.com on the harmony testnet

[justinasfour04]

Why are you shilling penguin. I'm telling it's not a good fix

[datpenguinclub]

@justinasfour04 I'm not shilling you my penguin - it costs you $0 to test it on the test network.

[justinasfour04]

How about you test it with other nfts
like pixel pirates or the frey or harmonauts

[datpenguinclub]

@justinasfour04 if you don't think it's a proper fix - you're welcome to give a better fix. I was just trying to tell you that my fix seems to fix not being able to view NFTs (attached screenshot above)..

Are any of these other projects like pixel pirates / freys and the harmonauts on the harmony testnet ?? if yes what's their URL ?? More than happy to test them out

[justinasfour04]

https://explorer.testnet.harmony.one/address/0xa5b261935bf555df9cc29b7801ddd00ce1800ff1

[datpenguinclub]

@justinasfour04 I'm just trying to tell you that this issue has been solved - and I have screenshots both on the testnet and mainnet - I'm not trying to shill you anything - not an opinion - a fact

That's an explorer page - I can't mint anything on there - I need URLs to the projects test environments running on the harmony testnet - not the explorer page.

[datpenguinclub]

@justinasfour04 Do you have the URL to testnet version of harmonauts / or freys / or any other Dapps you mentioned ?? I mentioned mine - cause I have a test version of my Dapp running on the harmony testnet - so you can test it without any real $$.

Cause we'd like to have end to end integration and best UX when users do use our Dapp. So I'm not shilling you anything, in fact no one is asking me to any of this - I'm just here trying to help. I'm signing off for now 😶🤷‍♂️

[justinasfour04]

Issue fixed in the following #111

[justinasfour04]

@datpenguinclub @givp @ethlocker @sophoah