feature:edited the page-header to serve as a navbar for mobile screen #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshmangalam
approved these changes
Oct 15, 2024
|
Hi @Vixs101 , Thank you so much for contributing to qwik-x during Hacktoberfest! Your efforts are truly appreciated, and we’d love to give you kudos and a shout-out for your amazing work. If you're comfortable, please feel free to share your social media handles like linkedin, twitter,etc... so we can tag you in our appreciation posts and spread the word about your contributions! Looking forward to seeing you in the community. Thanks again for being awesome! Best, |
|
HI @harshmangalam it's an honour contributing. thanks for letting a newbie like me help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** Closes #2
Hi so i noticed there was already a page header component on mobile, so I just added the logo, made the nav fixed, and added a border to the bottom of the nav to separate it from other contents.
here are some screenshots:
