Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Student Feedback - Chapter 11 #404

Closed
jasonjabbour opened this issue Aug 27, 2024 · 0 comments · Fixed by #518
Closed

Student Feedback - Chapter 11 #404

jasonjabbour opened this issue Aug 27, 2024 · 0 comments · Fixed by #518
Assignees
Labels
improvement Improve existing content

Comments

@jasonjabbour
Copy link
Collaborator

Chapter 11 - Benchmarking AI

  • We felt like we walked away with all learning objectives except for the seventh.
  • This chapter was interesting because it tried to broach a large topic (benchmarking) by tackling specific cases. While this was helpful, it resulted in a lot of the text being repetitive, as the same ideas were being re-introduced with only slightly different contexts. Also, benchmarks have been mentioned/defined several times up until this point, normally to help explain benchmarks for the topic of each chapter. Because of these two things, we feel like this chapter might be unnecessary. Rather, you can build up the explanation of benchmarks in each chapter, giving relevant information on benchmarks while still sticking to the topic of the chapter. Readers would still walk away with understanding of benchmarks in specific capacities, altogether giving them a general idea of what benchmarks are.
  • Some repetition in explanation that we noticed were across 11.4.4 Training Benchmarks, Metrics section and 11.4.5 Inference Benchmarks, Metrics section. These ideas were generally the same, and explanations of the each metric in both places did not feel necessary. Also, in 11.4.4 Training Benchmarks, MLPerf Training Benchmark is explained twice (and each explanation has a paragraph dedicated to it).
  • This chapter was also long; a potential place to cut down on text could be 11.5.1 Historical Context. The background information is nice, but not strictly necessary.
  • We didn't understand Figure 11.5 (sorry!)
  • The 11.5.3 Lessons Learned section felt like more of a conclusion---perhaps it should go towards the end of the chapter, rather than the middle.
  • Figure 11.7 is right under the 11.7 The Trifecta heading, but does not demonstrate the trifecta. Perhaps switch out this image with something more relevant?
    Machine Learning Systems - 11 Benchmarking AI.pdf

Originally posted by @sgiannuzzi39 in #256 (comment)

@jasonjabbour jasonjabbour self-assigned this Aug 27, 2024
@jasonjabbour jasonjabbour added the improvement Improve existing content label Aug 27, 2024
@harvard-edge harvard-edge deleted a comment from amir1387aht Aug 27, 2024
@harvard-edge harvard-edge deleted a comment Aug 27, 2024
@harvard-edge harvard-edge deleted a comment from amir1387aht Aug 27, 2024
@jasonjabbour jasonjabbour linked a pull request Nov 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve existing content
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants
@jasonjabbour and others