Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix unit tests and add build stats #26

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

starbops
Copy link
Member

@starbops starbops commented Feb 26, 2024

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Problem:

https://drone-publish.rancher.io/harvester/vm-dhcp-controller/32/1/2

Unit tests were broken due to a previously merged PR (#15).

Solution:

Fix the unit tests.

Related Issue:

N/A

Test plan:

N/A

@starbops starbops marked this pull request as ready for review February 26, 2024 07:37
Copy link
Contributor

@Yu-Jack Yu-Jack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@bk201 bk201 merged commit ecc9682 into harvester:main Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants