fix: change ippool agent pod's initcontainer's imagepullpolicy to ifn… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starbops
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
LGTM, thank you!
Just for the record: given that in the air-gapped environment, the PR fixes when users manually import the busybox container image to the nodes, kubelet will no longer make further requests to external registries to check for the digest. However, it's still an issue for harvester-vm-dhcp-agent running in air-gapped environments (without any private registry set up) because we don't pack the container image docker.io/library/busybox:latest in the ISO image initially.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…otpresent
IMPORTANT: Please do not create a Pull Request without creating an issue first.
Problem:
vm-dhcp-controller dhcpserver-agent Pod Fails to Start in Air-Gapped Environment Due to ImagePullPolicy 'Always' Setting，The initialization container is stuck in the “pull image” state.
Solution:
change the imagepullpolicy of the initialization container "ip-setter" to "IfNotPresent"。
Related Issue:
harvester/issues/6942
Test plan: