Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use {cid} as a placeholder for IPFS_PUBLIC_GATEWAY environment variable instead of ${cid} #4413

Open
Neurone opened this issue Nov 27, 2024 · 0 comments

Comments

@Neurone
Copy link
Contributor

Neurone commented Nov 27, 2024

Problem description

When using the ${cid} placeholder in the IPFS_PUBLIC_GATEWAY environment variable, developers must be careful to use single quotes instead of double quotes when specifying the value, otherwise in some contexts the ${cid} will be interpreted as the value of the cid environment value, resulting in an invalid value being passed to the system.

For example, if I set:

IPFS_PUBLIC_GATEWAY="https://ipfs.io/ipfs/${cid}"

The value of the env variable after the process is started will be https://ipfs.io/ipfs/ and not https://ipfs.io/ipfs/${cid} anymore.

Requirements

Use {cid} instead of ${cid} as a placeholder for the CID in the definition of the IPFS_PUBLIC_GATEWAY environment variable.

Definition of done

Developers don't need to worry about using single or double quotes when defining the values of the environment variables in the env configuration files.

@Neurone Neurone changed the title Use {cid} as a placeholder for IPFS_PUBLIC_GATEWAY environment variable instead of ${cid} Use {cid} as a placeholder for IPFS_PUBLIC_GATEWAY environment variable instead of ${cid} Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant