feat: Implement mint and burn
#106
Open
+327
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victor-yanev
added
the
feature
Signed-off-by: Victor Yanev <[email protected]>
victor-yanev
force-pushed
the
78-implement-burn-and-mint-of-HTS-tokens
branch
from
bce3576
to
c32669b
Compare
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # @hts-forking/out/HtsSystemContract.sol/HtsSystemContract.json
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…kens' Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
acuarica
reviewed
Nov 6, 2024
acuarica
reviewed
Nov 6, 2024
acuarica
reviewed
Nov 6, 2024
acuarica
reviewed
Nov 6, 2024
acuarica
reviewed
Nov 6, 2024
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # test/lib/TestSetup.sol
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…nd-mint-of-HTS-tokens Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # .gitignore # src/HtsSystemContract.sol # src/IHederaTokenService.sol # test/HTS.t.sol # test/lib/MocksToStorageLoader.sol
Signed-off-by: Victor Yanev <[email protected]>
…nd-mint-of-HTS-tokens Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # src/HtsSystemContract.sol
…nd-mint-of-HTS-tokens Signed-off-by: Victor Yanev <[email protected]> # Conflicts: # src/HtsSystemContract.sol
Signed-off-by: Victor Yanev <[email protected]>
…nd-mint-of-HTS-tokens Signed-off-by: Victor Yanev <[email protected]>
victor-yanev
changed the base branch from
main
to
108-Implement-getTokenInfo-v2
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
…nd-mint-of-HTS-tokens Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
acuarica
requested changes
Nov 22, 2024
Signed-off-by: Victor Yanev <[email protected]>
…S-tokens' into 78-implement-burn-and-mint-of-HTS-tokens Signed-off-by: Victor Yanev <[email protected]>
Signed-off-by: Victor Yanev <[email protected]>
acuarica
requested changes
Nov 25, 2024
| address from = address(bytes20(msg.data[40:60])); | ||
| address to = address(bytes20(msg.data[72:92])); | ||
| uint256 amount = uint256(bytes32(msg.data[92:124])); | ||
| _initTokenData(); |
There was a problem hiding this comment.
We shouldn't need this here. _update can also be called with transfers, where getTokenInfo shouldn't be needed. The main issue by having this here is that we may be triggering unnecessary requests to getTokenInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR:
Related issue(s):
Fixes #78
Notes for reviewer:
Checklist