-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of getAccountKey()
in DAppSigner
#184
Comments
Thanks, Adrian. I am using the mirror node as a workaround already now. It's not super urgent, I just saw it's not implemented and thought it might just have been forgotten. Thanks for pinging @hgraphql 😊 |
hey @regcs, would you be willing to make a PR to implement this function? |
Hi @tmctl, I have already worked on this and obtained some more understanding on the matter. I probably ran into the same issues as the initial developer who decided to not implement the method. Since we cannot derive the public key from the account ID, there are five options I can imagine:
IMO, options 1 to 3 are not really beneficial and can be handled by the developers themselves. Options 4 to 5 would require more efforts and maybe not an efficient time investment to solve this small issue. What are your opinions on that? |
@regcs could you clarify the need here, I'm unsure what exactly you're looking for, is it
Feel free to expand with user stories such as the below, these are often useful in helping others understand what you have in mind
|
@gregscullard Thanks, there is not much to expand on from my side. It's exactly what you wrote as a user stories. The origin was, that the |
Given the current architecture and the target solution being out of reach right now, it makes more sense to pursue this functionality as we are exploring the v2 upgrade to Reown. I will be closing this issue for now. |
Is your feature request related to a problem? Please describe. A clear and concise
description of what the problem is. Ex. I'm always frustrated when [...]
I wanted to extract the public key of the connected account via the
getAccountKey()
method. However, I encountered aError: Method not Implemented
. Obviously, this method is not implemented here:hedera-wallet-connect/src/lib/dapp/DAppSigner.ts
Line 114 in 88a3482
Describe the solution you'd like A clear and concise description of what you want to happen.
I would like to have this implemented and wonder what reason there is, that this was not implemented initially. Anyone, who can comment on this?
Describe alternatives you've considered A clear and concise description of any alternative
solutions or features you've considered.
None
Additional context Add any other context or screenshots about the feature request here.
None
The text was updated successfully, but these errors were encountered: