Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 82 should be reverted #259

Open
teacoat opened this issue Sep 6, 2024 · 0 comments
Open

PR 82 should be reverted #259

teacoat opened this issue Sep 6, 2024 · 0 comments
Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.

Comments

@teacoat
Copy link
Contributor

teacoat commented Sep 6, 2024

#82

This PR should be reverted, it is causing a lot of confusion among users. One of the core ideas behind walletconnect was a single-button for all wallets, this PR deviates from this and has introduced wallet-specific buttons into dapps. The walletconnect modal serves the purpose in a more robust way already.

Furthermore, this does not work well on mobile and introduces confusion for users trying to use these buttons.

I will be creating a PR for this but wanted to note it here for discussion.
@teacoat teacoat added the Improvement Code changes driven by non business requirements label Sep 6, 2024
@itsbrandondev itsbrandondev added the P1 High priority issue. Required to be completed in the assigned milestone. label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Code changes driven by non business requirements P1 High priority issue. Required to be completed in the assigned milestone.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teacoat @itsbrandondev