Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: minor fix enable demo forms #336

Merged
merged 6 commits into from
Nov 25, 2024
Merged

docs: minor fix enable demo forms #336

merged 6 commits into from
Nov 25, 2024

Conversation

kantorcodes
Copy link
Contributor

Description:
This PR adds a minor fix so that the javascript is loaded properly for the typescript embedded demo in /demos.

Notes for reviewer:
This change can be tested here: https://hwc-docs.hgraph.app/demos

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Signed-off-by: Michael Kantor <[email protected]>
Copy link

github-actions bot commented Nov 12, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.1% 478/620
🟡 Branches 63.08% 82/130
🟡 Functions 77.03% 114/148
🟡 Lines 78.26% 450/575

Test suite run success

115 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from c56a3e0

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@5ae78a5). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage        ?   36.05%           
=======================================
  Files           ?       14           
  Lines           ?      613           
  Branches        ?       79           
=======================================
  Hits            ?      221           
  Misses          ?      392           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tmctl tmctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no library change, just docs and demo.

lgtm

@kantorcodes kantorcodes merged commit 0051091 into main Nov 25, 2024
15 checks passed
@kantorcodes kantorcodes deleted the fix/CON-522 branch November 25, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants