Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add base64 example #355

Merged
merged 5 commits into from
Nov 26, 2024
Merged

docs: add base64 example #355

merged 5 commits into from
Nov 26, 2024

Conversation

kantorcodes
Copy link
Contributor

@kantorcodes kantorcodes commented Nov 25, 2024

Description:
Adds a small tool to test executing a base64 transaction directly. This has been super helpful in testing the SaucerSwap integration.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Michael Kantor <[email protected]>
Copy link

github-actions bot commented Nov 25, 2024

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements 77.1% 478/620
🟡 Branches 63.08% 82/130
🟡 Functions 77.03% 114/148
🟡 Lines 78.26% 450/575

Test suite run success

115 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from e39ef06

Comment on lines 592 to 664
<hr />
<h2>Pairing and session management:</h2>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you want these removing as the button title for disconnecting the sessions is obvious enough?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you want these removing as the button title for disconnecting the sessions is obvious enough?

haha no, I removed this by accident. Thanks for flagging

// Create multi-signature account
const handleCreateMultisigAccount = async () => {
// Fetch public keys from mirror node for each account
const fetchPublicKey = async (accountId: string) => {
const response = await fetch(
`https://testnet.mirrornode.hedera.com/api/v1/accounts/${accountId}`
`https://testnet.mirrornode.hedera.com/api/v1/accounts/${accountId}`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't need a comma here, is this part of the prettier config?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, that's because of prettier. It's also best practice to add trailing commas.

Copy link
Contributor

@tmctl tmctl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kantorcodes kantorcodes merged commit 2997127 into main Nov 26, 2024
15 checks passed
@kantorcodes kantorcodes deleted the base-64-demo branch November 26, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants