Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS/TS collisions #320

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Fix JS/TS collisions #320

merged 1 commit into from
Sep 5, 2023

Conversation

jeffdaley
Copy link
Contributor

Fixes JS/TS collisions that were causing this warning:

WARNING: Detected collisions between .js and .ts files of the same name. This can result in nondeterministic build output; see https://git.io/JvIwo for more information.

Using guidance from the issue thread, we now underscore the filenames of internal TS files (e.g., session.ts_session.ts) and then add a non-underscored .js file (e.g., session.js) that specifies the internal export.

  • Import path updates

@jeffdaley jeffdaley requested a review from a team as a code owner September 5, 2023 13:39
@jeffdaley jeffdaley merged commit 5d861ce into main Sep 5, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/collisions branch September 5, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants