Add types to Document route; Document-related cleanup #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
jeffdaley
force-pushed
the
jeffdaley/document-route
branch
from
f32b51a
to
f16922d
Compare
jeffdaley
changed the title
jeffdaley
force-pushed
the
jeffdaley/document-route
branch
from
35540aa
to
6712e10
Compare
jfreda
approved these changes
Sep 20, 2023
| @@ -42,7 +42,6 @@ | |||
| @owner={{get doc.owners 0}} | |||
| @productArea={{doc.product}} | |||
| @status={{lowercase doc.status}} | |||
| @thumbnail={{doc.googleMetadata.thumbnailLink}} | |||
There was a problem hiding this comment.
Hopefully we're going to add thumbnails back sooner than later, but I'll defer to you if you want to remove this before then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/routes/document.ts(which previously had a@ts-nocheck.createdDateformatting to a helper, a la ReplacemodifiedAgoproperty with template helper #323Frees up #335