Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update api.Allocations.Stop signature to use WriteOptions #18384

Open
MattJustMatt opened this issue Sep 5, 2023 · 1 comment
Open

update api.Allocations.Stop signature to use WriteOptions #18384

MattJustMatt opened this issue Sep 5, 2023 · 1 comment
Labels
hcc/jira stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/allocation API theme/api HTTP API and SDK issues theme/docs Documentation issues and enhancements

Comments

@MattJustMatt
Copy link
Contributor

nomad/api/allocations.go

Line 189 in 290a310

// BREAKING: This method will have the following signature in 1.6.0

The docs reference a change in the function signature for stopping allocations starting in Nomad 1.6.0-- I'm on 1.6.0 and the old signature is still used.
@jrasell
Copy link
Member

jrasell commented Sep 5, 2023

Hi @MattJustMatt and thanks for the reminder. We will take a look into this and make our next move.

@jrasell jrasell added theme/api HTTP API and SDK issues theme/allocation API stage/accepted Confirmed, and intend to work on. No timeline committment though. labels Sep 5, 2023
@tgross tgross moved this to Needs Roadmapping in Nomad - Community Issues Triage Jun 24, 2024
@tgross tgross added the theme/docs Documentation issues and enhancements label Jun 24, 2024
@tgross tgross changed the title Alloc stop signature not updated according to docs update api.Allocations.Stop signature to use WriteOptions Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hcc/jira stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/allocation API theme/api HTTP API and SDK issues theme/docs Documentation issues and enhancements
Projects
Nomad - Community Issues Triage
Status: Needs Roadmapping
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lgfa29 @tgross @jrasell @MattJustMatt