Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [ui] Add "stopped" as a valid status on jobs index/job detail into release/1.8.x #23338

Conversation

hc-github-team-nomad-core
Copy link
Contributor

Backport

This PR is auto-generated from #23328 to be assessed for backporting due to the inclusion of the label backport/1.8.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@philrenaud
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/nomad/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Our recent changes to how we label jobs in the UI considers any job "failed" if none of its expected allocations are running or pending, and it's not in active deployment.

This is coincidentally both true for jobs that failed because a user clicked the "stop" button, and also for jobs that failed because of the universe conspiring against us generally.

Luckily, jobs already had a nice Stop boolean to indicate the manual, deliberate stopping of a job (until it gets garbage collected, and provided it didn't have a "purge" flag passed in).

This PR observes that boolean and displays a new "Stopped" status in the UI in two places:

image image

resolves #22101


Overview of commits

Copy link

hashicorp-cla-app bot commented Jun 15, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Jun 17, 2024

Ember Test Audit comparison

release/1.8.x 9488d91 change
passes 1562 1563 +1
failures 2 2 0
flaky 0 0 0
duration 000ms 000ms -000ms

temp and others added 2 commits June 16, 2024 23:30
* Stopped status passed through to the statuses endpoint and observed on job model and steady-state panel

* Status passed to statuses endpoint and test for FE model statuses
@philrenaud philrenaud force-pushed the backport/f-ui/22101-ui-stopped-job-status/basically-alive-glider branch from b9da512 to 9488d91 Compare June 17, 2024 03:31
@philrenaud philrenaud marked this pull request as ready for review June 17, 2024 03:33
@philrenaud philrenaud merged commit 8ddc557 into release/1.8.x Jun 17, 2024
26 of 27 checks passed
@philrenaud philrenaud deleted the backport/f-ui/22101-ui-stopped-job-status/basically-alive-glider branch June 17, 2024 03:40
Copy link

github-actions bot commented Jan 3, 2025

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants