Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform state doesn't unlock if you cancel workflow running a terraform plan #441

Open
arianvp opened this issue Oct 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@arianvp
Copy link

arianvp commented Oct 18, 2024

Exactly what it says in the title. It seems the terraform wrapper isn't forwarding signals properly so the lock is never unclaimed. So when you cancel a workflow the lockfile needs to be manually cleaned up.

Dozens of people in this thread trying to come up with workarounds. But I think it's a bug in this action.

https://github.com/orgs/community/discussions/26311

@austinvalle
Copy link
Member

Hey there @arianvp 👋🏻, had a look through that thread and I agree that should be something the wrapper could be adjusted to properly forward the signals. We do rely on the @actions/exec package for executing the terraform process, but looks like someone in the community was already looking at adding this passthrough to that package for use in setup-terraform:

If that PR gets merged and released, I think we'd be open for a PR to adjust the wrapper to forward those signals through.

@austinvalle austinvalle added the enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants