Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Add tags support for aws_route53profiles_profile and aws_route53profiles_association #40241

Open
ineednewpajamas opened this issue Nov 21, 2024 · 3 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. service/route53profiles Issues and PRs that pertain to the route53profiles service.

Comments

@ineednewpajamas
Copy link

Description

Add support for the tags argument for aws_route53profiles_profile and aws_route53profiles_association. Tags are supported in awscc and the sdk.

Affected Resource(s) and/or Data Source(s)

aws_route53profiles_profile
aws_route53profiles_association

Potential Terraform Configuration

resource "aws_route53profiles_profile" "dev" {
  name = "example"

  tags = {
    Environment = "dev"
  }
}

References

https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/route53profiles_profile
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/route53profiles#CreateProfileInput

Would you like to implement a fix?

No

@ineednewpajamas ineednewpajamas added the enhancement Requests to existing resources that expand the functionality or scope. label Nov 21, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/route53profiles Issues and PRs that pertain to the route53profiles service. needs-triage Waiting for first response or review from a maintainer. labels Nov 21, 2024
@jeremychauvet
Copy link
Contributor

Hello @ineednewpajamas 👋🏼
Reviewing resource parameters, I've seen there's a tags_all attribute available.
Is it possible that this is matching what you're looking for?

@ineednewpajamas
Copy link
Author

tags_all which is just exported, and default_tags which is what feeds tags_all is not what I'm looking for. We need the ability to define specific tags for the resources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. service/route53profiles Issues and PRs that pertain to the route53profiles service.
Projects
None yet
Development

No branches or pull requests

2 participants