r/aws_amplify_domain_association.certificate_settings panic, diff and validation fixes

[taraspos]

Description

Fixing multiple issue with Amplify Domains:

• Fix panic when updating Amplify Domain
  • [Bug]: Crash Whilst Updating Amplify Domain Association #39890
• When certificate_settings is provided, but custom_certificate_arn is not provided, then it's treated as nil rather than empty string
  • [Bug]: Crash Whilst Updating Amplify Domain Association #39890#issuecomment-2506245444
• When certificate_settings is not provided, following diff is generated

            # aws_amplify_domain_association.test will be updated in-place
            ~ resource "aws_amplify_domain_association" "test" {
                  id                                  = "<redacted>"
                  # (6 unchanged attributes hidden)
          
                - certificate_settings {
                    - certificate_verification_dns_record = "<redacted>" -> null
                    - type                                = "AMPLIFY_MANAGED" -> null
                  }
          
                  # (1 unchanged block hidden)
              }

  • [Enhancement]: aws_amplify_domain_association certificate_settings AMPLIFY_MANAGED should be default #38387

Relations

Closes #39890
Closes #38387
Closes #38410

Output from Acceptance Testing

Seems like those tests were not run in a long time because of extra AMPLIFY_DOMAIN_NAME env variable needed. For example they were skipped in: #37105.

One test doesn't work because it tries to update domain without actually waiting for DNS/Certificate propagation to complete.

Error: updating Amplify Domain Association (): operation error Amplify: UpdateDomainAssociation, https response error StatusCode: 400, RequestID: 4f8e870f-e1d4-460b-8058-4c142862092b, BadRequestException: You cannot update a domain association while the certificate is updating. Try again once the ongoing update has completed.

---

➜ AMPLIFY_DOMAIN_NAME=<redacted> make testacc TESTS=TestAccAmplify_serial/DomainAssociation PKG=amplify
2024/11/28 17:43:45 Initializing Terraform AWS Provider...
=== RUN   TestAccAmplify_serial
=== PAUSE TestAccAmplify_serial
=== CONT  TestAccAmplify_serial
=== RUN   TestAccAmplify_serial/DomainAssociation
=== RUN   TestAccAmplify_serial/DomainAssociation/disappears
=== RUN   TestAccAmplify_serial/DomainAssociation/update
    domain_association_test.go:112: Step 3/3 error: Error running apply: exit status 1
        
        Error: updating Amplify Domain Association (<REDACED>): operation error Amplify: UpdateDomainAssociation, https response error StatusCode: 400, RequestID: 4f8e870f-e1d4-460b-8058-4c142862092b, BadRequestException: You cannot update a domain association while the certificate is updating. Try again once the ongoing update has completed.
        
          with aws_amplify_domain_association.test,
          on terraform_plugin_test.tf line 26, in resource "aws_amplify_domain_association" "test":
          26: resource "aws_amplify_domain_association" "test" {
        
=== RUN   TestAccAmplify_serial/DomainAssociation/basic
=== RUN   TestAccAmplify_serial/DomainAssociation/certificateSettings

--- FAIL: TestAccAmplify_serial (929.78s)
    --- FAIL: TestAccAmplify_serial/DomainAssociation (929.78s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/disappears (295.69s)
        --- FAIL: TestAccAmplify_serial/DomainAssociation/update (42.26s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/basic (295.70s)
        --- PASS: TestAccAmplify_serial/DomainAssociation/certificateSettings (296.13s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/amplify    937.268s
FAIL

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[github-actions]

Welcome @taraspos 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃