-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validations: remove PreferWriteOnlyAttribute
validations
#41562
Merged
Merged
+47
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Community NoteVoting for Prioritization
For Submitters
|
aws_ssm_paramter: add note to documentation about wo attribute usage
…_wo required with password_wo_version
9948c9b
to
fd9748c
Compare
jar-b
reviewed
Feb 26, 2025
jar-b
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Introduces or discusses updates to documentation.
prioritized
Part of the maintainer teams immediate focus. To be addressed within the current quarter.
service/docdb
Issues and PRs that pertain to the docdb service.
service/rds
Issues and PRs that pertain to the rds service.
service/redshift
Issues and PRs that pertain to the redshift service.
service/redshiftserverless
Issues and PRs that pertain to the redshiftserverless service.
service/secretsmanager
Issues and PRs that pertain to the secretsmanager service.
service/ssm
Issues and PRs that pertain to the ssm service.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PreferWriteOnlyAttribute
validation will be displayed as awarning
when the following conditions are met:write-only
attribute on a resource when one is availableThis warning can be polarizing since there is nothing wrong with the configuration and the validation is simply a suggestion.
This PR also adds additional
RequiredWith
validation to_wo
and_wo_version
attributesRelations
References
Output from Acceptance Testing