Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validations: remove PreferWriteOnlyAttribute validations #41562

Merged
merged 16 commits into from
Feb 26, 2025

Conversation

johnsonaj
Copy link
Contributor

@johnsonaj johnsonaj commented Feb 25, 2025

Description

PreferWriteOnlyAttribute validation will be displayed as a warning when the following conditions are met:

  • Using Terraform 1.11.0
  • Not using a write-only attribute on a resource when one is available

This warning can be polarizing since there is nothing wrong with the configuration and the validation is simply a suggestion.

This PR also adds additional RequiredWith validation to _wo and _wo_version attributes

image

Relations

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/ssm Issues and PRs that pertain to the ssm service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/docdb Issues and PRs that pertain to the docdb service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Feb 25, 2025
@johnsonaj johnsonaj force-pushed the f-d-write_only_validations branch from 9948c9b to fd9748c Compare February 26, 2025 15:51
@johnsonaj johnsonaj marked this pull request as ready for review February 26, 2025 15:57
@johnsonaj johnsonaj requested a review from a team as a code owner February 26, 2025 15:57
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@johnsonaj johnsonaj merged commit a262fcc into main Feb 26, 2025
41 checks passed
@johnsonaj johnsonaj deleted the f-d-write_only_validations branch February 26, 2025 18:26
@github-actions github-actions bot added this to the v5.89.0 milestone Feb 26, 2025
terraform-aws-provider bot pushed a commit that referenced this pull request Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/docdb Issues and PRs that pertain to the docdb service. service/rds Issues and PRs that pertain to the rds service. service/redshift Issues and PRs that pertain to the redshift service. service/redshiftserverless Issues and PRs that pertain to the redshiftserverless service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/ssm Issues and PRs that pertain to the ssm service.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants