Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state attribute to aws_dx_connection datasource #41575

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

catlike
Copy link
Contributor

@catlike catlike commented Feb 26, 2025

Description

Add state attribute to aws_dx_connection datasource, updated acceptance test and docs to include state

Relations

Closes #33746

Adds acceptance test to PR #38045 by @nikhil-goenka

References

AWS Direct Connect API connectionState attribute

Output from Acceptance Testing

make testacc TESTS=TestAccDirectConnectGatewayDataSource_basic PKG=directconnect

make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.5 test ./internal/service/directconnect/... -v -count 1 -parallel 20 -run='TestAccDirectConnectGatewayDataSource_basic'  -timeout 360m -vet=off
2025/02/26 19:44:50 Initializing Terraform AWS Provider...
=== RUN   TestAccDirectConnectGatewayDataSource_basic
=== PAUSE TestAccDirectConnectGatewayDataSource_basic
=== CONT  TestAccDirectConnectGatewayDataSource_basic
--- PASS: TestAccDirectConnectGatewayDataSource_basic (27.31s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/directconnect      27.499s

@catlike catlike requested a review from a team as a code owner February 26, 2025 20:07
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/directconnect Issues and PRs that pertain to the directconnect service. needs-triage Waiting for first response or review from a maintainer. labels Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. needs-triage Waiting for first response or review from a maintainer. service/directconnect Issues and PRs that pertain to the directconnect service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: aws_dx_connection output connection state
1 participant