Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot build Terraform v1.0.5 due to invalid tencentcloud-sdk-go dependency #29442

Closed
kevinburke opened this issue Aug 21, 2021 · 3 comments
Closed
Labels
bug new new issue not yet triaged

Comments

@kevinburke
Copy link
Contributor

kevinburke commented Aug 21, 2021

I attempted to check out the source code at tag v1.0.5 and then run:

GO111MODULE=on go install -v ./...

When I try this, I get the following error:

$ GO111MODULE=on go install -v ./...
go: github.com/tencentcloud/[email protected]+incompatible: reading github.com/tencentcloud/tencentcloud-sdk-go/go.mod at revision v3.0.82: unknown revision v3.0.82
go: downloading github.com/tencentcloud/tencentcloud-sdk-go v3.0.82+incompatible
go: github.com/tencentcloud/[email protected]+incompatible: reading github.com/tencentcloud/tencentcloud-sdk-go/go.mod at revision v3.0.82: unknown revision v3.0.82

It seems like this dependency changed their tagging mechanism, or did something to break the reference that Terraform is relying on. See TencentCloud/tencentcloud-sdk-go#125.

Since Terraform no longer vendors the source code it relies on, it's not clear what version of the Tencent dependency I am supposed to be running. Commit b543705 appears to have fixed this issue on tip, though it's not clear that it points at the same commit of the dependency.

As I understand it, 1.0.5 is the most recent stable release of Terraform, not a legacy release, so it seems like a problem that it is no longer possible to build this tag from source code. It would be great if you could release a new version that is possible to build from source.

Note that if you have a cached copy of this dependency locally, you may not be able to reproduce the issue.

Updates cycloidio/inframap#149.
Updates #29021.

@kevinburke kevinburke added bug new new issue not yet triaged labels Aug 21, 2021
@apparentlymart
Copy link
Contributor

Hi @kevinburke,

Indeed, the maintainers of this other module have retroactively deleted all of the tags from their repository and switched to using v1 major version tags instead, which has therefore broken all of their downstream dependencies.

As you've seen, we've since switched to referring to the particular commit that the v3.0.82 tag was previously referring to, which the developers recorded in a file in their repository.

The previously-existing tags are still cached in the official Go module proxy, as we can see by their documentation still being available, and so we're able to still build this tag by using that proxy to obtain the source code. However, I'd expect to see this error if not using the official module proxy, either due to disabling it altogether or by using a different proxy.

We're not planning to make an unscheduled release for this, but v1.0.6 is due next week and will include the updated dependency. Until then, if you need to build from source and can't use the official Go module proxy then an alternative is to locally patch go.mod to either use a replace directive for the version currently selected in main, or to modify the require entry for that dependency directly.

We've not yet seen any response from the maintainers of the upstream repository and so our actions so far have been based on local detective work. Hopefully the upstream maintainers will soon respond and explain what their plan is for this and how they expect downstream dependencies to respond to it.

@jbardin
Copy link
Member

jbardin commented Aug 30, 2021

Hi! The maintainer for that community backend updated the dependencies in #29445, which will be backported to the v1.0 branch.

Thanks!

@jbardin jbardin closed this as completed Aug 30, 2021
@github-actions
Copy link
Contributor

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug new new issue not yet triaged
Projects
None yet
Development

No branches or pull requests

3 participants