Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review fixes #2

Merged
merged 1 commit into from
Oct 15, 2021
Merged

review fixes #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/Intro.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const Intro = ({ title, description, image, buttons }) => {
</Link>
:
<Link key={index} href={value.link}>
<a className="btn btn-outline-primary my-1 mx-3">{value.title}</a>
<a target="_blank" rel="noreferrer" className="btn btn-outline-primary my-1 mx-3">{value.title}</a>
</Link>
))}
</div>
Expand Down
10 changes: 5 additions & 5 deletions config/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const navigation = {
}
export const intro = {
title: "Hey, I'm Hashir",
description: "I’m Computer Engineer. I create mobile apps and static websites.",
description: "A Computer Engineer creating mobile apps and static websites.",
image: profile.src,
buttons: [
{
Expand All @@ -45,9 +45,9 @@ export const intro = {
export const about = {
title: "Who I am",
description: [
"I graduated from National University of Sciences and Technology (NUST) in 2020 with a degree in Computer Engineering. I kick started my professional career as mobile application developer working remotely for a UK based startup — Lessgo.",
"I graduated from National University of Sciences and Technology (NUST) in 2020 with a degree in Computer Engineering. I kick started my professional career as a mobile application developer working remotely for a UK based startup — Lessgo.",
"The tech industry is ever-evolving and I love being able to grow with it, while continually solidifying the fundamentals. I opensource my code from a place of empathy - for future developers, teammates, users, and with accessibility in mind. I also love joining communities, helping and mentoring new developers, and supporting organizations to promote diversity in tech. I’m sharing my programming journey on instagram, helping people who are just getting into the space of programming.",
"When I’m not programming, I focus on my hobbies which are: diary writting, doodling, meeting people and growing my network.",
"When I’m not programming, I focus on my hobbies which are: diary writing, doodling, meeting people and growing my network.",
],
}

Expand All @@ -56,12 +56,12 @@ export const work = {
cards: [
{
title: "Mobile App Development",
description: "I create pixel perfect iOS and Andriod apps. Using Flutter.",
description: "I create pixel perfect iOS and Andriod apps using Flutter.",
icons: null,
},
{
title: "Web Development",
description: "I create responsive static websites. Using Reactjs.",
description: "I create responsive static websites using Reactjs.",
icons: null,
}
],
Expand Down