Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parsing Backpack signatures. #355

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ezyang
Copy link

@ezyang ezyang commented Mar 12, 2017

signature is an upcoming syntax extension in GHC 8.2, which just makes it possible to replace the top-level "module" keyword with "signature". For now, I drop information about which header is used, because I didn't want to change the AST.

Signed-off-by: Edward Z. Yang [email protected]

@mpickering
Copy link
Collaborator

Three things

  1. There needs to be a test
  2. I can't find where this is described in the user guide, please can you link me to the relevant part.
  3. The shift/reduce conflicts need to be explained. It seems that there shouldn't be any with this patch.

@ezyang
Copy link
Author

ezyang commented May 29, 2017

Re 2, see http://ghc.readthedocs.io/en/latest/separate_compilation.html#module-signatures

Actually, thinking about this more carefully, the shift/reduce error results in a legitimate problem parsing certain modules, which I filed at http://ghc.haskell.org/trac/ghc/ticket/13765 So I guess we need a separate parsing mode for hsig files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants