Skip to content

Commit

Permalink
Remove unnecessary -fvia-C check
Browse files Browse the repository at this point in the history
Brandon’s review/II.
  • Loading branch information
ffaf1 committed Nov 11, 2023
1 parent a051dd6 commit d4e43fc
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
3 changes: 0 additions & 3 deletions Cabal/src/Distribution/PackageDescription/Check/Target.hs
Original file line number Diff line number Diff line change
Expand Up @@ -802,9 +802,6 @@ checkGHCOptions title t opts = do
checkFlags
["-fasm"]
(PackageDistInexcusable $ OptFasm title)
checkFlags
["-fvia-C"]
(PackageDistSuspicious $ OptViaC title)
checkFlags
["-fhpc"]
(PackageDistInexcusable $ OptHpc title)
Expand Down
8 changes: 0 additions & 8 deletions Cabal/src/Distribution/PackageDescription/Check/Warning.hs
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ data CheckExplanation
| SubdirRelPath
| SubdirGoodRelPath String
| OptFasm String
| OptViaC String
| OptHpc String
| OptProf String
| OptO String
Expand Down Expand Up @@ -520,13 +519,6 @@ ppExplanation (OptFasm fieldName) =
++ fieldName
++ ": -fasm' is unnecessary and will not work on CPU "
++ "architectures other than x86, x86-64, ppc or sparc."
ppExplanation (OptViaC fieldName) =
"'"
++ fieldName
++ ": -fvia-C' is usually unnecessary. If your package "
++ "needs -via-C for correctness rather than performance then it "
++ "is using the FFI incorrectly and will probably not work with GHC "
++ "6.10 or later."
ppExplanation (OptHpc fieldName) =
"'"
++ fieldName
Expand Down

0 comments on commit d4e43fc

Please sign in to comment.