From d4e43fc7d0b744b090d32e02f21fde00a400ddd7 Mon Sep 17 00:00:00 2001
From: Francesco Ariis <fa-ml@ariis.it>
Date: Thu, 9 Nov 2023 23:20:37 +0100
Subject: [PATCH] Remove unnecessary `-fvia-C` check
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Brandon’s review/II.
---
 Cabal/src/Distribution/PackageDescription/Check/Target.hs | 3 ---
 .../src/Distribution/PackageDescription/Check/Warning.hs  | 8 --------
 2 files changed, 11 deletions(-)

diff --git a/Cabal/src/Distribution/PackageDescription/Check/Target.hs b/Cabal/src/Distribution/PackageDescription/Check/Target.hs
index f3cb7d3d8c1..99ae5a8d379 100644
--- a/Cabal/src/Distribution/PackageDescription/Check/Target.hs
+++ b/Cabal/src/Distribution/PackageDescription/Check/Target.hs
@@ -802,9 +802,6 @@ checkGHCOptions title t opts = do
       checkFlags
         ["-fasm"]
         (PackageDistInexcusable $ OptFasm title)
-      checkFlags
-        ["-fvia-C"]
-        (PackageDistSuspicious $ OptViaC title)
       checkFlags
         ["-fhpc"]
         (PackageDistInexcusable $ OptHpc title)
diff --git a/Cabal/src/Distribution/PackageDescription/Check/Warning.hs b/Cabal/src/Distribution/PackageDescription/Check/Warning.hs
index db1e8af7565..a8d9ac78195 100644
--- a/Cabal/src/Distribution/PackageDescription/Check/Warning.hs
+++ b/Cabal/src/Distribution/PackageDescription/Check/Warning.hs
@@ -164,7 +164,6 @@ data CheckExplanation
   | SubdirRelPath
   | SubdirGoodRelPath String
   | OptFasm String
-  | OptViaC String
   | OptHpc String
   | OptProf String
   | OptO String
@@ -520,13 +519,6 @@ ppExplanation (OptFasm fieldName) =
     ++ fieldName
     ++ ": -fasm' is unnecessary and will not work on CPU "
     ++ "architectures other than x86, x86-64, ppc or sparc."
-ppExplanation (OptViaC fieldName) =
-  "'"
-    ++ fieldName
-    ++ ": -fvia-C' is usually unnecessary. If your package "
-    ++ "needs -via-C for correctness rather than performance then it "
-    ++ "is using the FFI incorrectly and will probably not work with GHC "
-    ++ "6.10 or later."
 ppExplanation (OptHpc fieldName) =
   "'"
     ++ fieldName