Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-validate: Better output verbosity defaults #10573

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

9999years
Copy link
Collaborator

Closes #10569
Closes #10570

A new --quiet switch has been added, and some behavior in ./validate.sh (without --verbose) has been moved into --quiet mode:

  • --hide-successes will be passed to test suites in --quiet mode, making it easier to track tests as they run
  • Subprocess output is only captured in --quiet mode, making it easier to watch cabal build and test suite output

Some output has been hidden unless --verbose is used:

  • The build plan (listing of all local packages and transitive dependencies) and the dry-run build used to produce the build plan are skipped unless --verbose is given
  • The runtime configuration (e.g. the ghc and cabal-install executables being used) and tool versions are not printed unless --verbose is given

Additionally, print-config, print-tool-versions, and time-summary are no longer explicit steps, and are instead run implicitly. This means that ./validate.sh -v -s build will print the config and tool versions; they do not have to be listed explicitly.

time-summary is redundant in its current form and is removed. It may be added back in the future with more detailed output (e.g., which steps were run, how long did they take individually). (Partially closes #10571)

@9999years 9999years added the cabal-validate validate.sh (cabal-validate) test suite runner label Nov 21, 2024
`print-config`, `print-tool-versions`, and `time-summary` are no longer
explicit steps, and are instead run implicitly (closes haskell#10570).

`time-summary` is redundant in its current form and is removed. It may
be added back in the future with more detailed output (e.g., which steps
were run, how long did they take individually).

`print-config` and `print-tool-versions` are hidden unless `--verbose`
is given.
Hide the build plan (listing of local packages and transitive
dependencies) unless `--verbose` is given.
Doesn't do anything yet.
These are no longer explicit steps and will be printed at the start of
each `validate.sh` run individually. (This is more accurate because
flags like `--with-cabal` and `--extra-hc`, which are only used in some
steps, influence the configuration and tool versions in use.)
@9999years 9999years marked this pull request as ready for review November 25, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal-validate validate.sh (cabal-validate) test suite runner
Projects
None yet
1 participant