VCS: Don't run submodule commands unless necessary #10590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `git submodule` commands is harmless but clutters up the logs, making the tests difficult to debug when run in verbose-mode. Doesn't seem to impact performance much. I measured a ~1.5% speedup with this code, which is well within error margins. See: https://github.com/haskell/cabal/pull/7625/files#r709617991
9999years
force-pushed
the
vcs-submodules
branch
from
14094a4
to
4f63e9e
Compare
5 tasks
geekosaur
approved these changes
Nov 22, 2024
|
No PR template? I think this is borderline needing a changelog file. Ideally, it wouldn't change anything and won't be noticed, but it is a change in behaviour, strictly speaking. I'd lean on a safe side and add a changelog. |
|
Added a changelog entry! Also added a PR to change the PR template to one I wouldn't delete so much (#10594) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
git submodulecommands is harmless but clutters up the logs, making the tests difficult to debug when run in verbose-mode.Doesn't seem to impact performance much. I measured a ~1.5% speedup with this code, which is well within error margins.
See: https://github.com/haskell/cabal/pull/7625/files#r709617991