Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: guide on profiling: fix the title #10606

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ulysses4ever
Copy link
Collaborator

Please read Github PR Conventions and then fill in one of these two templates.


Template B: This PR does not modify behaviour or interface

E.g. the PR only touches documentation or tests, does refactorings, etc.

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • [N/A] Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the file should be renamed as well….

@Kleidukos
Copy link
Member

@malteneuss Does this align with the vision you had for this guide?

@jasagredo
Copy link
Collaborator

jasagredo commented Nov 28, 2024

I would be a bit less succinct and say something like "How to configure a project for profiling" or "Configuring a project for profiling".

But the current title is also fine for me, so I'll approve

@ulysses4ever
Copy link
Collaborator Author

I would be a bit less succinct and say something like "How to configure a project for profiling" or "Configuring a project for profiling".

Thanks, I'm open for options. I am not a fan of the first because it's a little lengthy, and the second deviates from the pattern that's established in the guide section: everything starts from "How to" (maybe not a great decision but it should be applied or unapplied consistently). Let's see what @malteneuss and others has to say.

Seems like the file should be renamed as well….

I was being lazy, sorry! Fixed.

@malteneuss
Copy link
Collaborator

The title was chosen to be more beginner friendly and to be immediately understandable even when someone doesn't know the correct technical term "profiling", i.e. people who are more likely to need a guide. Imagine what you would search if you didn't know that term: probably "measure haskell performance" or similar. Still, the guide uses the term "profiling" enough times to be locatable via Google easily for someone who knows.

While "analyze .. performance" isn't technically correct yet, (e.g. we don't explain how to to interpret results), that could be added later (even by just referencing the optimization book or GHC guide). It's also a relatively short title. Alternatives could have been "How to setup Cabal to measure Haskell performance" if it wasn't so long.

@ulysses4ever
Copy link
Collaborator Author

While "analyze .. performance" isn't technically correct yet, (e.g. we don't explain how to to interpret results), that could be added later

Let's not get ahead of ourselves. Only when and if such an addition is implemented can we discuss a title that reflects that new content. Besides, @jasagredo and I argued that it's not Cabal Guide's job to teach people to interpret GHC profiles. So, I am doubtful that such an addition will even happen. Of course, others may rule otherwise.

The title was chosen to be more beginner friendly and to be immediately understandable even when someone doesn't know the correct technical term "profiling", i.e. people who are more likely to need a guide. Imagine what you would search if you didn't know that term: probably "measure haskell performance" or similar. Still, the guide uses the term "profiling" enough times to be locatable via Google easily for someone who knows.

I think Cabal Guide shouldn't be targeted at CS freshmen. The average reader is not very familiar with Haskell but is somewhat familiar with computer programming. So, I'd expect them to be aware of the notion of "profiling".

How about:

How to enable collection of performance statistics (profiling)

for the title?

@ulysses4ever
Copy link
Collaborator Author

(question for all)

@jasagredo
Copy link
Collaborator

I'm in favor of:

How to enable collection of performance statistics (profiling)

@malteneuss
Copy link
Collaborator

Good enough for me

@Kleidukos
Copy link
Member

Good enough for me too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants