Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing instances #327

Open
konsumlamm opened this issue Dec 23, 2021 · 1 comment
Open

Missing instances #327

konsumlamm opened this issue Dec 23, 2021 · 1 comment

Comments

@konsumlamm
Copy link
Contributor

  • ByteArray is missing a Read instance.
  • PrimArray is missing a Read and a Data instance.
@andrewthad
Copy link
Collaborator

I would accept PRs for all of these. I'm fine with Read instances being more permissive than the Show instances. (For example, the Read instance for ByteArray might accept both decimal-encoded numbers or hexadecimal-encoded numbers even though the Show instance only produces hexadecimal-encoded numbers.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrewthad @konsumlamm