Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting with case insensitivity #6

Closed
dag opened this issue Jun 8, 2012 · 9 comments · Fixed by #385
Closed

Sorting with case insensitivity #6

dag opened this issue Jun 8, 2012 · 9 comments · Fixed by #385
Labels

Comments

@dag
Copy link

dag commented Jun 8, 2012

If I have

import Happstack.Server
import HSP

stylish-haskell will sort it as

import HSP
import Happstack.Server

This is contrary to my expectation and wishes.

@jaspervdj
Copy link
Member

Makes sense, will fix!

@dag
Copy link
Author

dag commented Jun 8, 2012

Just make sure you don't mess up sorting of import lists in the process. ;) That is, we still want types, names and operators sorted separately (but perhaps case-insensitively within each group).

jaspervdj added a commit that referenced this issue Jun 8, 2012
@vlatkoB
Copy link

vlatkoB commented Nov 5, 2021

This is happening again. Can we reopen this issue?

@EncodePanda
Copy link
Contributor

Could you please contribute with a test that fails? I will be happy to make that test green :)

@vlatkoB
Copy link

vlatkoB commented Nov 5, 2021

I tested the above

import Happstack.Server
import HSP

Or do you mean to make a PR with failed test?

@EncodePanda
Copy link
Contributor

Or do you mean to make a PR with failed test?

Yes, please. That would be most valuable.
Please create a branch where you add a new test that shows the expected behavior. Open a PR. The test will fail, I will make it work :)

@vlatkoB
Copy link

vlatkoB commented Nov 5, 2021

Created, #383

@vlatkoB
Copy link

vlatkoB commented Nov 21, 2021

@EncodePanda Was the PR good? I see it is still in 1 workflow awaiting approval status.

@vlatkoB
Copy link

vlatkoB commented Nov 24, 2021

Thanks. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants