ChatCompletionClient
cannot be used in a standard compliant system due to exception access modifiers + inconsistent service exception access modifiers.
#235
Gummimundur
started this conversation in
General
Replies: 1 comment
-
Yes all exceptions should be public. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
@hassanhabib @ElbekDeveloper @BrianLParker
Some of the
ChatCompletionClient
exceptions areinternal
and others arepublic
therefore the following problem occurs when trying to integrate this library in a standard compliant system. TheChatCompletionClient
exceptions should all be public, right?Also there are inconsistent access modifiers in the service exceptions. For example
InvalidConfigurationChatCompletionException
is internal whileInvalidConfigurationCompletionException
is public. Which one should it be? Should all the service level exceptions bepublic
? Allinternal
? Or should it depend on something else?Beta Was this translation helpful? Give feedback.
All reactions