Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing] duplicate invitation #76

Open
2 tasks
cch5ng opened this issue Jun 6, 2020 · 1 comment
Open
2 tasks

[testing] duplicate invitation #76

cch5ng opened this issue Jun 6, 2020 · 1 comment
Assignees

Comments

@cch5ng
Copy link
Collaborator

cch5ng commented Jun 6, 2020

  • cleanup duplicate invitation definition

  • set init id on message on the client side (needed in order to update the message with appropriate translation)


(update) the reason why this matters is because if there are duplicate approved invitations in the database, this could cause inconsistencies in saving and retrieving conversations

revisit testing for duplicate invitation logic

while testing the updated validation error display on invitation dialog, I felt like some invitations were sent to existing contacts. so maybe the definition of duplicate needs to be expanded

@cch5ng cch5ng self-assigned this Jun 6, 2020
@cch5ng
Copy link
Collaborator Author

cch5ng commented Jun 8, 2020

put on hold; was working on testing for case: send invite to registered and non registered users (test dupe invitation)

already tested case (send invite to only registered users)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant