Enable bugprone-string-integer-assignment

Enable this clang-tidy check and fix related issues.
haukeschuemann · Aug 9, 2019 · f382c09 · f382c09
1 parent f31fcb0
commit f382c09
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -19,7 +19,6 @@ performance-*,\
 readability-*,\
 -bugprone-misplaced-widening-cast,\
 -bugprone-narrowing-conversions,\
--bugprone-string-integer-assignment,\
 -bugprone-too-small-loop-variable,\
 -bugprone-undefined-memory-manipulation,\
 -bugprone-unused-return-value,\

diff --git a/src/computer.cpp b/src/computer.cpp
@@ -1809,15 +1809,15 @@ void computer::print_gibberish_line()
     for( int i = 0; i < length; i++ ) {
         switch( rng( 0, 4 ) ) {
             case 0:
-                gibberish += '0' + rng( 0, 9 );
+                gibberish += static_cast<char>( '0' + rng( 0, 9 ) );
                 break;
             case 1:
             case 2:
-                gibberish += 'a' + rng( 0, 25 );
+                gibberish += static_cast<char>( 'a' + rng( 0, 25 ) );
                 break;
             case 3:
             case 4:
-                gibberish += 'A' + rng( 0, 25 );
+                gibberish += static_cast<char>( 'A' + rng( 0, 25 ) );
                 break;
         }
     }