Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api.github.com limits on number of requests causes the request to fail #87

Closed
haxorof opened this issue Mar 9, 2019 · 1 comment
Closed
Labels

Comments

@haxorof
Copy link
Owner

haxorof commented Mar 9, 2019

Currently installation of docker-compose in this role uses the api.github.com to determine latest version. This API is limited to number of requests so in bigger environments that uses this the request limit might be reached and causes the request to fail.

Ansible Version

2.7.8

Role Version

2.2.0

Role configuration

docker_compose: true
docker_compose_no_pip: true
...

Expected Behavior

Docker compose successfully downloaded and installed.

Actual Behavior

Task Get latest release of docker-compose failed

Steps to Reproduce

---
- name: Test install of Docker compose not using PiP
  hosts: test-host
  vars:
    docker_compose: true
    docker_compose_no_pip: true
  roles:
    - haxorof.docker-ce
...

References

@haxorof haxorof added the fix label Mar 9, 2019
haxorof added a commit that referenced this issue May 30, 2019
@haxorof
Copy link
Owner Author

haxorof commented May 30, 2019

Added new configuration options to fix this:

# Uses Github API to lookup latest version of docker compose
docker_compose_no_pip_detect_version: true
# Docker compose version to use if no automatic lookup is used
docker_compose_no_pip_version: 1.24.0

@haxorof haxorof closed this as completed May 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant