Skip to content
This repository has been archived by the owner on Nov 25, 2023. It is now read-only.

model package should not use domains package #517

Open
z2sx opened this issue May 10, 2021 · 3 comments
Open

model package should not use domains package #517

z2sx opened this issue May 10, 2021 · 3 comments
Assignees

Comments

@z2sx
Copy link
Contributor

z2sx commented May 10, 2021

Domains is for VDoc and other domains, model domain should be fully defined by core and model package should rely on core only. Please let me know if you have any concerns about this.

@z2sx
Copy link
Contributor Author

z2sx commented May 10, 2021

To achieve this, very likely we need to move tx domain to core. This is fine, because we're going to implement modifiable model and model-specific Txes will live in core.

@haiodo
Copy link
Member

haiodo commented May 11, 2021

Right now model is not a real model but a DLS + model definition combined from core(classes mostly) + model( tx, space, references, etc).

Should we think about?

  1. model -> model-dsl (without a real models), it will depend only on core, since require classes.
  2. model -> core-model - > a model definitions for core. (will contain model.ts)
  3. model -> domains-model -> a model definitions for domains. (will contain model.ts)
  4. model -> model-cli - will scan and import all model.ts files and generate a real model into (DB, json, etc).

@z2sx
Copy link
Contributor Author

z2sx commented May 11, 2021

Too much separation for now and would not help to understand minimal core requirements. To achieve this it's enough to move model-domains out of model (3). 1, 2 & 4 will rely on core and can stay in model for now.

haiodo added a commit that referenced this issue May 19, 2021
Move model definitions to core-model, domains-model

Closes #517

Signed-off-by: Andrey Sobolev <[email protected]>
@haiodo haiodo mentioned this issue May 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants